Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce gRPC connection create #3184

Merged
merged 8 commits into from
Jun 20, 2022
Merged

reduce gRPC connection create #3184

merged 8 commits into from
Jun 20, 2022

Conversation

champly
Copy link
Contributor

@champly champly commented Jun 17, 2022 •
edited by JorTurFer
Loading

Signed-off-by: champly champly@outlook.com

  • Reduce gRPC connections and scalerAddress multiplexing connections with the same address.
  • Fix WaitGroup is reused before previous Wait has returned panic error.

Fix: #3193

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements

@champly
reduce gRPC connection create
cf2b1e5 
Signed-off-by: champly <champly@outlook.com>
@champly champly requested a review from a team as a code owner June 17, 2022 01:57
@JorTurFer
Copy link
Member

JorTurFer commented Jun 17, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progress here

@JorTurFer
Copy link
Member

JorTurFer commented Jun 17, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progress here

@JorTurFer
Copy link
Member

hey @champly
Thanks for the improvement!
e2e tests fail after this change, could you take a look? 🙏

@champly
remove WaitGroup to fix panic error
35fb066 
Signed-off-by: champly <champly@outlook.com>
@champly
add changelog
dcc0807 
Signed-off-by: champly <champly@outlook.com>
@champly
fix ci check
ed30d33 
Signed-off-by: champly <champly@outlook.com>
@champly
add ut
8445be4 
Signed-off-by: champly <champly@outlook.com>
@champly
Merge branch 'main' into fix-gRPC-connect
f9f6d3a 
Signed-off-by: champly <champly@outlook.com>
@champly
fix static check
4c04dda 
Signed-off-by: champly <champly@outlook.com>
@JorTurFer
Copy link
Member

JorTurFer commented Jun 20, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progress here

@champly
Copy link
Contributor Author

champly commented Jun 20, 2022

hey @champly Thanks for the improvement! e2e tests fail after this change, could you take a look? 🙏

already to fix, PTAL.

JorTurFer
JorTurFer reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good ❤️
Only small nit related with changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@champly
modify changelog
4da90a0 
Signed-off-by: champly <champly@outlook.com>
@JorTurFer
Copy link
Member

JorTurFer commented Jun 20, 2022 •
edited by github-actions bot
Loading

/run-e2e external*
Update: You can check the progress here

@JorTurFer JorTurFer merged commit f5508eb into kedacore:main Jun 20, 2022
@champly champly deleted the fix-gRPC-connect branch June 20, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

external server create too may gRPC connection
2 participants
@champly @JorTurFer