fix: Adapter has high qps to apiserver

[bamboo12366]

Provide a description of what has been changed

Checklist

• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• [N/A] Tests have been added
• [N/A] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• [N/A] A PR is opened to update the documentation on (repo) (if applicable)
• Changelog has been updated and is aligned with our changelog requirements

Fixes #2914

[zroubalik]

Looking good, could you please also pass the same client to the handler on line 106? So we can get rid of the kubeclient completely?

Also, have you been able to test this setup to see if it really helped with the issue?

[bamboo12366]

could you please also pass the same client to the handler on line 106? So we can get rid of the kubeclient completely?

will do later

have you been able to test this setup to see if it really helped with the issue?

I test the image locally, only the first request will hit the apiserver, after there are only list from informer cache(guaranteed by list-watch)

[zroubalik]

Cool :)

Then please also fix DCO and update the Changelog, that's a great improvement!

[bamboo12366]

@zroubalik Can I just skip the test case in this PR? Since this one only mitigate the burden to Apiserver, will not affect the performance/logic in Keda side

[zroubalik]

@zroubalik Can I just skip the test case in this PR? Since this one only mitigate the burden to Apiserver, will not affect the performance/logic in Keda side

@bamboo12366 yeah, no need for test in this case.

[JorTurFer]

LGTM
Awesome improvement! ❤️
Only 2 small nits inline

[zroubalik]

/run-e2e
Update: You can check the progres here

[JorTurFer]

/run-e2e
Update: You can check the progres here

[JorTurFer]

/run-e2e
Update: You can check the progres here

[JorTurFer]

I'm not sure how, but it seems that these changes are breaking e2e tests. They have failed 3 times in a row when in main branch they are working. Maybe e2e tests are based on this wrong approach, I'll take a look deeper asap

[JorTurFer]

/run-e2e
Update: You can check the progres here

[zroubalik]

/run-e2e mysql*
Update: You can check the progres here

[zroubalik]

/run-e2e argo*
Update: You can check the progres here

[JorTurFer]

Hey @bamboo12366
We plan to do a release during next week. I have solved the problems with e2e tests (they were in other places, not in your changes), could you rebase your branch and update the changelog? 🙏
I'll trigger e2e test again and once they pass, we can merge it to include this improvement in next release

[bamboo12366]

@JorTurFer I update CHANLOG and resolve conflicts accordingly, could you please help me review again to see if everything fit?

[JorTurFer]

/run-e2e
Update: You can check the progres here

Failure is expected, but only graphite scaler

[JorTurFer]

I'm not sure about what commit breaks the DCO check @bamboo12366, but at least 1 commit is not signed.
Could you squash your branch for just pushing your commits (signed)?

[bamboo12366]

sorry I am not that familiar with git. I already merge the rebase and merge the main into current branch, I don't know how to squash commit now, could you advise more? @JorTurFer

[JorTurFer]

sorry I am not that familiar with git. I already merge the rebase and merge the main into current branch, I don't know how to squash commit now, could you advise more? @JorTurFer

Sure, you can do this:

git checkout yourBranch
git reset $(git merge-base main $(git branch --show-current))
git add -A
git commit -sm "one commit on yourBranch"

Squash the branch is not mandatory, but it's the easiest way to ensure all commits are signed (because only 1 needs to be signed xD)

[bamboo12366]

sorry I am not that familiar with git. I already merge the rebase and merge the main into current branch, I don't know how to squash commit now, could you advise more? @JorTurFer

Sure, you can do this:

git checkout yourBranch
git reset $(git merge-base main $(git branch --show-current))
git add -A
git commit -sm "one commit on yourBranch"

Squash the branch is not mandatory, but it's the easiest way to ensure all commits are signed (because only 1 needs to be signed xD)

Thanks A Lot!! You truly save my live!

[JorTurFer]

/run-e2e
Update: You can check the progres here