RELEASE-PROCESS.MD: make warning about required template changes more prominent #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
|
/cc @zroubalik |
JorTurFer
approved these changes
Mar 23, 2022
zroubalik
approved these changes
Mar 23, 2022
|
@chalin seems like static checks are failing on some formatting issue, could you please look at it? |
Signed-off-by: Patrice Chalin <pchalin@gmail.com>
|
All checks are passing now ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In followup to these two issues:
this PR updates the release-process notes to:
<INSERT-CORRECT-VERSION>because that makes the text disappear when the markdown is rendered/previewed -- since the renderer considers it to be a HTML tag. (It might be a good idea to remove all angle brackets from that template)/cc @tomkerkhove