Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide e2e variables for Azure Key Vault #2756

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Conversation

tomkerkhove
Copy link
Member

Provide e2e variables for Azure Key Vault.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Relates to #900
Relates to #2727

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkerkhove please add it to 1Password

@zroubalik zroubalik merged commit 489c4e2 into main Mar 14, 2022
@zroubalik zroubalik deleted the key-vault-e2e branch March 14, 2022 10:46
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants