Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix returns unmatched error when updating hpa object failed #2677

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Fix returns unmatched error when updating hpa object failed #2677

merged 2 commits into from
Mar 17, 2022

Conversation

Shitaibin
Copy link
Contributor

@Shitaibin Shitaibin commented Feb 27, 2022 •
edited by zroubalik
Loading

In updateHPAIfNeeded, it should return error of update hpa object not newHPAForScaledObject, if updating failed.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #2719

@Shitaibin Shitaibin requested a review from a team as a code owner February 27, 2022 06:28
zroubalik
zroubalik reviewed Feb 28, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Could you please create a short issue and link it here in the PR, so we can track it properly? And could you please update Changelog as well? Thanks

@Shitaibin
Copy link
Contributor Author

Looking good! Could you please create a short issue and link it here in the PR, so we can track it properly? And could you please update Changelog as well? Thanks

@zroubalik OK. I've created an issue and updated the change log.

@zroubalik
Copy link
Member

zroubalik commented Mar 7, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

zroubalik
zroubalik reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a nit in Changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

zroubalik commented Mar 11, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

@zroubalik
Copy link
Member

@Shitaibin could you please rebase and update this PR, we have some changes in e2e tests in the main branch that we need in order to execute e2e tests properly.

@Shitaibin
Copy link
Contributor Author

/run-e2e

@Shitaibin
Copy link
Contributor Author

/run-e2e

@Shitaibin
Copy link
Contributor Author

/run-e2e

@zroubalik it seems the e2e has not been triggered. Anything wrong?

BTW, I recently read KEAD codes and ran the examples. I have a question. Could you answer it for me. Thanks.

I didn't figure out how the scale controller and hpa controller modify the same scale sub resource at the same time, when the scale trigger is inactive. Why hpa didn't reset the replica of workload to min repilca after scale controller set the replica to 0?

@zroubalik
Copy link
Member

/run-e2e

@zroubalik it seems the e2e has not been triggered. Anything wrong?

Only maintainers could start e2e, I'll do that.

BTW, I recently read KEAD codes and ran the examples. I have a question. Could you answer it for me. Thanks.

I didn't figure out how the scale controller and hpa controller modify the same scale sub resource at the same time, when the scale trigger is inactive. Why hpa didn't reset the replica of workload to min repilca after scale controller set the replica to 0?

HPA Controller pauses scaling if min replica is set to 0 (on HPA).

@zroubalik
Copy link
Member

zroubalik commented Mar 16, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progres here

zroubalik
zroubalik reviewed Mar 17, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Update CHANGELOG.md
d86fdc1 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit 88d57ca into kedacore:main Mar 17, 2022
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@Shitaibin @zroubalik @RamCohen
Fix returns unmatched error when updating hpa object failed (kedacore…
5243a81 
…#2677)

Signed-off-by: shitaibin <hz_stb@163.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returns unmatched error when updating hpa object failed
2 participants
@Shitaibin @zroubalik