Don't call Azure queue GetProperties API unnecessarily #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reorders the logic of getting an Azure queue size in a way that skips the call to get the queue properties (for getting the ApproximateMessagesCount) if the queue has less than 32 messages. Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
|
/run-e2e azure-queue* |
JorTurFer
reviewed
Feb 9, 2022
|
/run-e2eazure-queue.test* |
JorTurFer
previously approved these changes
Feb 9, 2022
JorTurFer
requested changes
Feb 9, 2022
|
hey @RamCohen |
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
|
There is a conflict in the changelog. |
JorTurFer
approved these changes
Feb 11, 2022
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorders the logic of getting an Azure queue size in a way
that skips the call to get the queue properties (for getting the
ApproximateMessagesCount) if the queue has less than 32 messages.
Signed-off-by: Ram Cohen ram.cohen@gmail.com