Add GitHub OIDC Token into GITHUB_TOKEN for signing images #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
zroubalik
approved these changes
Jan 24, 2022
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
…2504) Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
markrzasa
pushed a commit
to markrzasa/keda
that referenced
this pull request
Jan 27, 2022
…2504) Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Signed-off-by: Mark Rzasa <mark.rzasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
For being able to sign the images with the token, we should specify the requirement of
GitHub OIDC Tokenin GITHUB_TOKEN. This pushes to add all the needed permission because once you request 1, you have to specify all of them.Instead of adding all available permissions in the token, I added those I think we use, but please review it
Checklist
Related #2501 #2502
Fixes #2386