Raises an error when RabbitMQ regex matches more than 1 page #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
zroubalik
approved these changes
Sep 20, 2021
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
…e#2103) Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we were talking during the last meeting, this PR modifies the behavior of RabbitMQ Scaler to raise an error in case of the provided regex matches with more queues those are returned in a single page. At least with this PR, the user get information about why the scaler doesn't reflect the current status of the queues (if they need 2 or more pages)
Checklist
Fixes #2068