Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keda should scale from zero when minReplicaCount is set #523

Closed
ekcasey opened this issue Dec 20, 2019 · 2 comments · Fixed by #524
Closed

keda should scale from zero when minReplicaCount is set #523

ekcasey opened this issue Dec 20, 2019 · 2 comments · Fixed by #524
Assignees
@zroubalik
Labels
bug Something isn't working

Comments

@ekcasey
Copy link

ekcasey commented Dec 20, 2019 •
edited
Loading

keda does not respect scaledobject.spec.minReplicaCount when the actual deployment has 0 replicas.

Expected Behavior

If scaledobject.spec.minReplicaCount is set to n, keda should ensuring that the deployment has at least n replicas, scaling from 0 if necessary.

Actual Behavior

If a deployment is has minReplicaCount but was initially created with 0 replicas, minReplicaCount is not respected and the deployment is not scaled from 0.

Steps to Reproduce the Problem

  1. create a deployment with zero replicas
  2. create a scaled object for that deployment with minReplicaCount equal to 1
  3. observe that the deployment remains at 0 replicas

Specifications

  • Version: v1.0.0 and master
  • Scaler(s): all
@ekcasey ekcasey added the bug Something isn't working label Dec 20, 2019
ekcasey added a commit to ekcasey/system that referenced this issue Dec 20, 2019
@ekcasey
fats waits for processor to scale from zero
1159d8d 
* keda will not scale from zero before there is traffic kedacore/keda#523

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@ekcasey ekcasey mentioned this issue Dec 20, 2019
Closed
ekcasey added a commit to ekcasey/system that referenced this issue Dec 21, 2019
@ekcasey
fats waits for processor to scale from zero
3c7c3b5 
* keda will not scale from zero before there is traffic kedacore/keda#523

Signed-off-by: Emily Casey <ecasey@pivotal.io>
@zroubalik zroubalik self-assigned this Dec 21, 2019
@zroubalik
Copy link
Member

zroubalik commented Dec 21, 2019 •
edited
Loading

thanks @ekcasey, good catch, will take a look at this

@zroubalik zroubalik mentioned this issue Dec 21, 2019
Merged
@anirudhgarg
Copy link
Contributor

Looks like this is merged.

preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
@arschles
Add doc about custom http timeout in RabbitMQ Scaler (kedacore#523)
d9df408 
Co-authored-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zroubalik zroubalik

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scale from zero when minReplicaCount is > 0 zroubalik/keda
3 participants
@zroubalik @ekcasey @anirudhgarg