Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for explicitly pausing autoscaling of ScaledJobs #3303

Closed
tomkerkhove opened this issue Jun 30, 2022 · 6 comments · Fixed by #4558
Closed

Provide support for explicitly pausing autoscaling of ScaledJobs #3303

tomkerkhove opened this issue Jun 30, 2022 · 6 comments · Fixed by #4558
Labels
feature All issues for new features that have been committed to

Comments

@tomkerkhove
Copy link
Member

tomkerkhove commented Jun 30, 2022 •
edited
Loading

Proposal

Provide support for explicitly pausing autoscaling of ScaledJobs so that it no longer spins up new jobs.

This should be done by applying the autoscaling.keda.sh/paused: true annotation on the ScaledJobs resource.

Use-Case

Avoid scaling when:

  • Cluster is having resource starvation
  • Doing maintenance
  • ...

Anything else?

Follow-up for #944
@tomkerkhove tomkerkhove added the feature All issues for new features that have been committed to label Jun 30, 2022
This was referenced Jun 30, 2022
Closed
Closed
@keegancwinchester
Copy link

I am interested in contributing to this issue! I will begin to work on this.

@tomkerkhove
Copy link
Member Author

Thank you @keeganwinchester-shipt!

@tomkerkhove tomkerkhove mentioned this issue Jul 14, 2022
Closed
5 tasks
@zroubalik
Copy link
Member

autoscaling.keda.sh/is-paused: true - I personally don't like the is- part of this at all. It gives me an impression that it describes a state rather than setting the action.

I'd use autoscaling.keda.sh/paused: true instead

@tomkerkhove @JorTurFer ^^

@tomkerkhove
Copy link
Member Author

Fine by me, I thought that was what we agreed on but I'll update the spec

@JorTurFer
Copy link
Member

I agree

This was referenced Sep 8, 2022
Closed
Closed
This was referenced Oct 28, 2022
Closed
Closed
@keegancwinchester keegancwinchester mentioned this issue Nov 7, 2022
Closed
6 tasks
@tomkerkhove tomkerkhove added the help wanted Looking for support from community label May 4, 2023
@tomkerkhove tomkerkhove added planning:microsoft-engineering and removed help wanted Looking for support from community labels May 23, 2023
@tomkerkhove tomkerkhove mentioned this issue May 23, 2023
Merged
7 tasks
@tomkerkhove
Copy link
Member Author

This is being worked on by @flux-benj in #3303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature All issues for new features that have been committed to
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
4 participants
@zroubalik @tomkerkhove @JorTurFer @keegancwinchester