Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for SAS tokens for authentication in Azure Service … #938

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

v-shenoy
Copy link
Contributor

…Bus scaler.

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#2920

@v-shenoy v-shenoy requested a review from a team as a code owner September 15, 2022 18:19
@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 44bfce9
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/63294e1b525088000801735d
😎 Deploy Preview https://deploy-preview-938--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…Bus scaler.

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer JorTurFer merged commit ca52816 into kedacore:main Sep 20, 2022
@tomkerkhove
Copy link
Member

Let's make sure the feature gets merged ASAP to keep it in sync :D

@JorTurFer
Copy link
Member

There is no feature to merge, I added support to it as side effect when I migrated the SDK xD

@v-shenoy v-shenoy deleted the sb-sas branch September 20, 2022 07:46
@tomkerkhove
Copy link
Member

Yes there is - kedacore/keda#3673

@JorTurFer
Copy link
Member

It's only to update the changelog, the feature itself is ready xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants