Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStack Swift scaler contract #386

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

pdominguite
Copy link
Contributor

@pdominguite pdominguite commented Mar 3, 2021

Signed-off-by: Pedro Felipe Dominguite (p.dominguite@sidi.org.br)

Changes

  • The swiftURL is now an optional parameter since it can be retrieved from the catalog.
  • The optional parameter regionName was added.
  • Since the scaler only supports Keystone v3, the parameter /v3 shouldn't be passed to the URL path as before.

Relates to: #1652

Signed-off-by: Pedro Felipe Dominguite <p.dominguite@sidi.org.br>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit 62d2aaf into kedacore:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants