Documentation for ClusterTriggerAuthentication #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
coderanger
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
suggested changes
Jan 4, 2021
4 tasks
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
The wording in the new |
zroubalik
reviewed
Jan 5, 2021
There was a problem hiding this comment.
Looking good, thanks! Minor nits:
Could you please update this part of the docs as well?
https://github.com/kedacore/keda-docs/blob/master/content/docs/2.1/concepts/_index.md#custom-resources-crd
The beginning of content/docs/2.1/concepts/authentication.md (section around * Re-use credentials or delegate authentication with TriggerAuthentication)
Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
|
Not sure what's up with the failed build. Transient issue? |
|
@coderanger yeah, we can ignore those. Thanks for the update, it is looking good! |
zroubalik
approved these changes
Jan 6, 2021
tomkerkhove
approved these changes
Jan 6, 2021
Signed-off-by: Noah Kantrowitz <noah@coderanger.net> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs PR for kedacore/keda#1452
Relates to kedacore/keda#1469