Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes Gateway APIs for Ingress #33

Closed
Tracked by #350
beriberikix opened this issue Feb 2, 2021 · 10 comments
Closed
Tracked by #350

Support Kubernetes Gateway APIs for Ingress #33

beriberikix opened this issue Feb 2, 2021 · 10 comments
Labels
enhancement New feature or request feature traffic-sources All issues related to where HTTP traffic can come from

Comments

@beriberikix
Copy link

beriberikix commented Feb 2, 2021

The network SIG has been hard at work developing the new Gateway API, aka Ingress V2. A Gateway is responsible for routing a request to a service. There's already an HTTPRoute implementation. The API has several integration points and I think the current Interceptor could be integrated or evolved to integrate with the existing HTTP implementation. Alternatively, a new GatewayClass can be designed to work specifically with KEDA and still make use of the standardized API.

Might relate to #10 and possibly #6. /cc folks from Services API who know way more than I do :) @hbagdi @jpeach @robscott

Edit @tomkerkhove: Updated link given it was renamed to Gateway API.

@arschles
Copy link
Collaborator

arschles commented Feb 2, 2021

@beriberikix sounds like it'd be useful to have the operate create service API resources instead of (in addition to?) Ingress resources that #10 calls for (I think the operator should support both)

Another aspect is metrics. We can do routing with this, but is there a standard metrics API that this comes with? SMI is certainly one solution but something designed explicitly for north-south traffic, as you said in today's meeting, could be more beneficial.

Looking forward to hearing your thoughts!

@tomkerkhove
Copy link
Member

I think the same here @arschles - Folks should be able to choose if we manage it or they bring their own imo

@beriberikix
Copy link
Author

beriberikix commented Feb 3, 2021

💯! It's also entirely possible someone has a very custom Ingress solution and this shouldn't prevent them as well. Services API should be in addition to Ingress (and user choice which to instantiate), especially since Ingress V1 is currently the only GA supported way and Service API is still in Beta Alpha.

@arschles great questions on Metrics. I've asked in #sig-network-service-apis channel for input!

@hbagdi
Copy link

hbagdi commented Feb 4, 2021

Service API is still in Beta.

nit: Service APIs (or Gateway API in future) is in alpha.

It's also entirely possible someone has a very custom Ingress solution and this shouldn't prevent them as well. Services API should be in addition to Ingress

That's correct. Based on the community interest, it seems like most ingress controllers will add support for Service APIs in future. Ingress isn't going anywhere.

@beriberikix
Copy link
Author

RE: metrics @robscott:

There’s interest in this but it’s not a core priority. We’re trying to focus on getting all the core parts of the API right first but could eventually expand the scope to include this. This could be a good opportunity for an implementation to experiment with a potential spec for metrics and then work on upstreaming it if it works well.

@arschles arschles added the enhancement New feature or request label Feb 9, 2021
@tomkerkhove tomkerkhove added the traffic-sources All issues related to where HTTP traffic can come from label Feb 12, 2021
@arschles
Copy link
Collaborator

@beriberikix sorry for the loooong delay here. I've been pretty focused on #206 for a while now, so haven't had a chance to come back to this. I'm not sure how feasible this would be, but could the interceptor herein be a good testing ground for adding metrics?

@stale
Copy link

stale bot commented Oct 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 25, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 26, 2021
@arschles
Copy link
Collaborator

Let's keep this open. Adding the feature label so the stale bot won't try to close this again.

@tomkerkhove tomkerkhove changed the title Support Kubernetes Service APIs for Ingress Support Kubernetes Gateway APIs for Ingress Dec 16, 2021
kingdonb pushed a commit to kingdonb/http-add-on that referenced this issue Jun 12, 2023
…-5k5lqd

Delete cluster: vcluster/vcluster
@zroubalik
Copy link
Member

What exactly do we need to add/implement in order to fully support GW API? Is there anything left? CC @wozniakjan

@wozniakjan
Copy link
Member

Is there anything left?

I just need to find some time to finish #1052, but after that imho not much left with the currently considered scope for both Ingress and HTTPRoute. Both are documented equally and will be covered by similar e2e tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature traffic-sources All issues related to where HTTP traffic can come from
Projects
Status: Done
Development

No branches or pull requests

6 participants