fix: check for scripts dir in project root instead of /scripts #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. I seem to remember there’s a reason we did it this way. I’ll have to check the git history to confirm. |
|
I think the issue was that for github actions to work, this is run in a Docker instance, and in Docker the scripts folder is mounted to Line 7 in 0bad620 But looking at the rest of the Dockerfile, I don't see why it wouldn't work. I'm happy to merge and see if it works. If it doesn't I might have to revert again. |
|
Perhaps it could do with a comment explaining the root prefix is intentionally for when in docker/gh-actions? Or maybe check for $GITHUB_ACTION to make the intention explicit in code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems this check would always fail except maybe in some CI setups.