-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-server): serve css files #601
Conversation
Great job @timols, let's fix couple of small issues and we can merge it in:
|
@@ -113,7 +115,14 @@ var createKarmaSourceHandler = function(promiseContainer, staticFolder, adapterF | |||
} | |||
} | |||
|
|||
return util.format(SCRIPT_TAG, scriptType, filePath); | |||
if (filePath.search(/.css/) > 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you write this in "node" style:
if (xxx) {
return util.format(LINK_TAG, ...);
}
return util.format(SCRIPT_TAG, ...);
Also, change the regexp to not match /some.css/folder/file.js
:
if (/\.css$/.test(filePath))
Great. Thanks for the feedback. I'll fix these issues shortly. |
@vojtajina I think all items are now resolved. Please let me know if I need to address anything else. |
feat(web-server): serve css files
Great, thank you very much @timols ! |
Any chance we can get a canary build out for these changes? |
Closes #431