Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove circular reference in Browser #3076

Merged
merged 1 commit into from
Jul 11, 2018

Commits on Jul 10, 2018

  1. fix: remove circular reference in Browser

    After migrating the the `browser.js` file to ES2015, the `Browser` class has now fields with circular references (like `emitter`),
    which breaks the Karma JSON reporters available starting with Karma 2.0.1.
    This commit removes the circular dependencies by adding a `toJSON()` method to the `Browser` class,
    which produces a similar result to the browser object before the migration.
    
    Fixes karma-runner#3075
    cexbrayat committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    f573076 View commit details
    Browse the repository at this point in the history