Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flaky-test): Add time to beforeEach() to allow plugins to load on first pass. #3025

Merged
merged 1 commit into from
Jun 4, 2018
Merged

fix(flaky-test): Add time to beforeEach() to allow plugins to load on first pass. #3025

merged 1 commit into from
Jun 4, 2018

Commits on Jun 4, 2018

  1. fix(flaky-test): Add time to beforeEach() to allow plugins to load on… 

    … first pass.

Loading plugins in beforeEach seems unwise: the it() blocks potentially run against different environments. In particular the first it() block runs with the timer already worn down by the plugin load and often the timeout hits on my mac air before the test passes.Until we can restructure this code a longer timeout avoids flaky tests.
    @johnjbarton
    johnjbarton committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    8e5ebb6 View commit details
    Browse the repository at this point in the history