Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forEach in lib/middleware/karma.js #2678

Closed

Conversation

BenjaminVanRyseghem
Copy link

Use forEach instead of for..in as it's better
practices and fix #2671.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@BenjaminVanRyseghem
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Use `forEach` instead of `for..in` as it's better
practices and fix karma-runner#2671.
@dignifiedquire
Copy link
Member

Thank you but we can not make this change, .forEach assumes that files is an unmodified array with an intact prototype, but we had issues where that was not the case.

@BenjaminVanRyseghem
Copy link
Author

Thanks for the pointer.

I'll see if I can get another workaround 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Karma is not able to run if any methods in Array.prototype are modified beforehand.
3 participants