fix(files): Ignore included:false pattern #1974
Conversation
| files = [ | ||
| {pattern: 'files/log_foo.js', included: false}, | ||
| {pattern: 'files/log_foo.js', included: true}, | ||
| 'files/*.js' |
There was a problem hiding this comment.
It would be good to have one test case where files/*.js is the first entry.
|
@dignifiedquire There's an integration test that fails, because it assumes some other semantic than the proposed precedence. Should the test be changed or should the semantics? |
budde377
force-pushed
the
feature-issue-1530
branch
from
187a61c
to
8279277
Compare
|
@budde377 right, so we have to think about this carefully, because in the 0.12 and before the semantics where that the most specific pattern would match, rather than |
|
@dignifiedquire. Lets do this the cool way! Inspired by the CSS specificity calculations, we should define a specificity-measure. I propose the following: Minimatch supports:
Given a path, p, we can define a tuple s(p) = (ng, nw, ne, nb) where ng, nw, ne, and nb are the number of globstars, wildcards, extended glob match patterns, and brace expansion patterns, respectively. With any two paths, p and q, where s(p)=(p1, p2, p3, p4) and s(q)=(q1, q2, q3, q4) we can define a order of the corresponding tuples p1 < p2 ⇔ ∃ m > 0: ∀ i > m: pi = qi ∧ pm < qm i.e. an lexicographical order. Given two paths with different tuples, we can define the one with the smallest tuple (wrt. the order above) as the most specific. If the tuples are equal we can choose either one. |
|
Or we could just let the number of files generated from a given pattern decide how specific it is. The more files, the less specific. |
|
@budde377 💯 for the cool order you suggested above. We just need to make sure to document and test this well, so people understand what's happening :) |
|
@dignifiedquire Yes. I'll start on it this afternoon. |
|
After some failed attempts, I'm pretty sure that I have a solution. I'll have it implemented and tested primo next week. |
|
Thanks @budde377 for the great work, looking forward to see it :) |
budde377
force-pushed
the
feature-issue-1530
branch
from
04ff204
to
737f872
Compare
Define specificity of patterns. Let most specific pattern decide to include files or not. Closes karma-runner#1530
budde377
force-pushed
the
feature-issue-1530
branch
from
737f872
to
db42a7f
Compare
|
@dignifiedquire I've now implemented an order. Please let me know if it needs more documentation etc. |
|
Nice work, will review more closely tomorrow |
| it('should calculate right weight of pattern with more magic', () => { | ||
| helper.mmPatternWeight('{0..9}/?(a|b)c/[abc]/**/*.jsx?').should.be.deep.equal([10, 1, 1, 1, 1, 1]) | ||
| }) | ||
| it('should calculate right weight of pattern as worst glob set', () => { |
|
Thanks @budde377 looking good, going to merge this and hope for the best :) |
fix(files): Ignore included:false pattern
Do not include a file, when
include=false.Give
include=falseprecedence overinclude=true.Closes #1530