Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade to lodash 4.0.0 #1855

Closed

Conversation

testower
Copy link
Contributor

Closes #1812

@testower
Copy link
Contributor Author

Seems like karma-coverage's lodash also needs to be upgraded? _.contains is removed in favor of _.includes in lodash 4.0.0, and upping the version in karma, forces karma-coverage to use it as well.


31 01 2016 21:47:22.042:WARN [preprocess]: Can not load "coverage"!
  TypeError: _.contains is not a function
  at createCoveragePreprocessor (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma-coverage/lib/preprocessor.js:54:10)
  at Array.invoke (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:75:15)
  at [object Object].get (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:48:43)
  at instantiatePreprocessor (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/lib/preprocessor.js:52:20)
  at Array.forEach (native)
  at /Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/lib/preprocessor.js:68:21
  at Array.forEach (native)
  at createPreprocessor (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/lib/preprocessor.js:67:12)
  at Array.invoke (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:75:15)
  at get (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:48:43)
  at /Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:71:14
  at Array.map (native)
  at [object Object].invoke (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/node_modules/di/lib/injector.js:70:31)
  at [object Object].Server.start (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/lib/server.js:95:18)
  at Object.exports.run (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/lib/cli.js:246:26)
  at Object.<anonymous> (/Users/testower/Developer/karma/integration-tests/coverage-coffee/node_modules/karma/bin/karma:3:23)
  at Module._compile (module.js:434:26)
  at Object.Module._extensions..js (module.js:452:10)
  at Module.load (module.js:355:32)
  at Function.Module._load (module.js:310:12)
  at Function.Module.runMain (module.js:475:10)
  at startup (node.js:117:18)
  at node.js:951:3

@dignifiedquire
Copy link
Member

The problem is that karma exposes helper._ which is lodash, so some plugins rely on this, so we need to check all plugins (and this will be a breaking change)

@dignifiedquire
Copy link
Member

I have thought about it a little bit more and I think I want for the next major release to drop helper._ so that I don't run into this issue anymore. It's pretty easy to upgrade, just need to make sure to release new versions of all the different plugins that rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants