Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flaky-test): Add time to beforeEach() to allow plugins to load on first pass. #3025

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

johnjbarton
Copy link
Contributor

No description provided.

@johnjbarton
Copy link
Contributor Author

I will rebase after the eslintignore PR.

@johnjbarton johnjbarton requested a review from kyliau June 1, 2018 17:07
… first pass.

Loading plugins in beforeEach seems unwise: the it() blocks potentially run against different environments. In particular the first it() block runs with the timer already worn down by the plugin load and often the timeout hits on my mac air before the test passes.Until we can restructure this code a longer timeout avoids flaky tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants