Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 8 Support #2754

Closed
joerideg opened this issue Jun 29, 2017 · 5 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122, Omrisnyk/npm-lockfiles#132 or satoshinakamoto007/bitcore#1135
Closed

Node 8 Support #2754

joerideg opened this issue Jun 29, 2017 · 5 comments · Fixed by karronoli/redpen#10 · May be fixed by Omrisnyk/npm-lockfiles#122, Omrisnyk/npm-lockfiles#132 or satoshinakamoto007/bitcore#1135

Comments

@joerideg
Copy link

Expected behaviour

I can install and run karma using Node 8

Actual behaviour

Karma will fail to install because engine support has not included Node 8 yet.

Hi,
First of all thanks for your hard work on this great open source project.

Could you guys please add support for Node 8, and/or give us a timeline for when this change will be released to the public.

@shaiksphere
Copy link

Is there an update on this one? This is blocking the usage of karma on the Node 8 based projects of ours.

The pull request has been sitting idle since June 29.

@joerideg
Copy link
Author

It seems the pull request fixing this has been merged. Awesome work guys!

@shaiksphere
Copy link

Great (thumbsup)

Any idea when the 1.7.1 will be released containing the fix?

cletusw pushed a commit to cletusw/karma that referenced this issue Aug 29, 2017
dignifiedquire pushed a commit that referenced this issue Aug 30, 2017
@cletusw
Copy link

cletusw commented Aug 30, 2017

@shaiksphere 1.7.1 has just been released with this fix in #2818 !

@shaiksphere
Copy link

Thank you @cletusw. This issue will pop up again in a few months when Node 9.x will be released. Will there be a better solution to make sure it doesn't break again every 6 months or so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment