Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the tap area for the recording mode. #2222

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Implement the tap area for the recording mode. #2222

merged 6 commits into from
Apr 21, 2024

Conversation

andy840119
Copy link
Member

Implement part of #2207 to improve the recording experience.

image
image

Add this shit for:

  • Record the time-tag time by click the mouse.
  • Clear all time-tag time in the single lyric and re-recording again.
  • Move to previous lyric.

@andy840119 andy840119 added the LyricMaker Implement lyric maker part into karaoke ruleset. label Apr 21, 2024
@andy840119 andy840119 added this to the 2024.0707 milestone Apr 21, 2024
@andy840119 andy840119 self-assigned this Apr 21, 2024
@andy840119 andy840119 merged commit c291b58 into karaoke-dev:master Apr 21, 2024
3 of 4 checks passed
@andy840119 andy840119 deleted the implement-the-tap-area branch April 21, 2024 16:20
@andy840119 andy840119 mentioned this pull request Apr 24, 2024
Merged
@andy840119 andy840119 mentioned this pull request Aug 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andy840119 andy840119

Labels
LyricMaker Implement lyric maker part into karaoke ruleset. size/XL
Projects
None yet
Milestone
2024.06015
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119