Use #gets rather than #read to read from pipe in System#call

This solves the issue with indefinite-blocking when trying to get the Chromium version packaged via snap on Debian/Ubuntu, mentioned in titusfortner#168
kapoorlakshya · May 23, 2020 · ea64bf5 · ea64bf5
1 parent a50315e
commit ea64bf5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/webdrivers/system.rb b/lib/webdrivers/system.rb
@@ -156,7 +156,7 @@ def call(process, arg = nil)
         cmd = arg ? [process, arg] : process # Windows provides powershell command (process) only, no args.
         Webdrivers.logger.debug "making System call: #{cmd}"
         p = IO.popen(cmd)
-        out = p.read
+        out = p.gets
         p.close
         raise "Failed to make system call: #{cmd}" unless $CHILD_STATUS.success?