Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new namespace #43

Merged
merged 60 commits into from
Mar 15, 2019
Merged

Create new namespace #43

merged 60 commits into from
Mar 15, 2019

Conversation

kapoorlakshya
Copy link
Owner

@kapoorlakshya kapoorlakshya commented Mar 5, 2019 •
edited
Loading

#32

  1. Now uses ScreenRecorder as top level module. FFMPEG is not directly exposed anymore.
  2. The recording modes are now available through ScreenRecorder::Desktop and ScreenRecorder::Window classes to make the usage (parameters) straight forward.
  3. Method parameters are now keywords instead of an opts Hash.
  4. framerate: is now to be passed through the advanced Hash. The default is 15.0 as it is a sweet spot between smoothness and low filesize.

To Do

  • Update README
  • Merge after beta11 release

@kapoorlakshya
Rename folder to match the gem name.
b1a2df2
@kapoorlakshya
Class ScreenRecorder is Common now.
ef5a6e0
@kapoorlakshya
Create Desktop class will handle desktop recording parameters.
7652144
@kapoorlakshya
Move all helper modules under ScreenRecorder module.
d85d7df
@kapoorlakshya
RecorderOptions class is Options now.
84325c9
@kapoorlakshya
RecorderErrors class is Errors now.
cb2d5ed
@kapoorlakshya
WindowTitles class is Titles now.
1464b6c
@kapoorlakshya
Require all renamed files.
ecf34a8
@kapoorlakshya
Remove input as a required option.
76927cb
@kapoorlakshya
Create Desktop and Window classes based on Common.
e00376c
@kapoorlakshya
Merge branch '32_create_new_namespace' of https://github.com/kapoorla…
106f2fb 
…kshya/ffmpeg-screenrecorder into 32_create_new_namespace
@kapoorlakshya
Fix bad merge conflict resolution.
980267f
@kapoorlakshya
Fix params for Options.
099b375
@kapoorlakshya
Fix namespace for VERSION.
28373b0
@kapoorlakshya
Fix spec for Common.
222a160
@kapoorlakshya
Make basic Desktop specs pass.
67c1cb4
@kapoorlakshya
Format is now referred to as inpuy device to match the FFmpeg termino…
5dc7d75 
…logy.
@kapoorlakshya
Test advanced options for Desktop.
1e716da
@kapoorlakshya
Switch to own logger implementation from FFMPEG.logger.
bd0549e
@kapoorlakshya
Fix a bug where input was not defaulted to 0 when 'desktop' was passe…
eb5b40b 
…d as input.
@kapoorlakshya
Rename specs for Titles and Options to match their class names.
fc9c811
@kapoorlakshya
Revert "Fix a bug where input was not defaulted to 0 when 'desktop' w…
15e9805 
…as passed as input."

This reverts commit eb5b40b.
@kapoorlakshya
Slightly improve input determination logic for Desktop mode, and add …
8b00ae1 
…a spec to test it.
@kapoorlakshya
Add ScreenRecorder#ffmpeg_binary=() to wrap around FFMPEG#ffmpeg_bina…
cef94d0 
…ry=().
@kapoorlakshya
Update doc for Desktop#determine_input.
d714b67
@kapoorlakshya
ScreenRecorder::Window now raises a NotImplementedError if the curren…
4c26ddb 
…t OS is not Microsoft Windows.
@kapoorlakshya
Make Options spec pass.
0357c09
@kapoorlakshya
Update Titles specs.
332262b
@kapoorlakshya
Fix a bug where the framerate was not correctly defaulted.
402c044
@kapoorlakshya
Fix equal matcher in Desktop spec.
64c142c
@kapoorlakshya
Replace xvfb-run -n param with --server-num as -n seems to have been …
06a1a32 
…removed.
@kapoorlakshya
Remove server-number and see if screen 0 works by itself.
a79548c
@kapoorlakshya
Revert "Remove server-number and see if screen 0 works by itself."
e633cb0 
This reverts commit a79548c.
@kapoorlakshya
Fix assignment of --server-num.
0b71198
@kapoorlakshya
Revert "Temporarily add a debug statement."
62f0d82 
This reverts commit d783771.
@kapoorlakshya
Revert "Set to :0.0 using export command in before_script."
e8511d4 
This reverts commit 8f82720.
@kapoorlakshya
Set to :0.0.
b7faab6
@kapoorlakshya
Require Window class.
3f387d1
@kapoorlakshya
Force encode retrieve titles to be UTF-8.
c16bca3
@kapoorlakshya
Revert "Force encode retrieve titles to be UTF-8."
3029b07 
This reverts commit c16bca3.
@kapoorlakshya
Options - Make input a required option.
2783193
@kapoorlakshya
Options#determine_capture_device - Now respects :fmt param for ffmpeg…
14ed35a 
…'s capture device.
@kapoorlakshya
Custom ffmpeg log filename is set through advanced[:log] now.
361ee0d
@kapoorlakshya
Update README.
91d3033
@kapoorlakshya
README - Remove references to FFMPEG module that is no longer exposed.
59747d0
@kapoorlakshya
README - Update description for Fetch Titles section.
8f737ec
@kapoorlakshya
README - Update window recording title to include windows only.
ee387db
@kapoorlakshya
More README updates.
69e821c
@kapoorlakshya kapoorlakshya mentioned this pull request Mar 12, 2019
Closed
11 tasks
@kapoorlakshya kapoorlakshya merged commit f8258ae into master Mar 15, 2019
@kapoorlakshya kapoorlakshya deleted the 32_create_new_namespace branch March 15, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kapoorlakshya