Function uniqueId always returns a 12 chars id #930
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function uniqueId was making this library "impure". The output of the minifier could be different from one call to another using the same input and using the option
maxLineLength
.Let me explain:
The function
joinResultSegments
is relying on the segments length to decide whether to add a newline separator or not when joining them while using the optionmaxLineLength
. As the functionuniqueId
was generating a random length ID, sometimes you could have different outputs with HTML elements being moved to a new line while it wasn't on a previous call.I changed the code of
uniqueId
a bit so that the returned ID is always a 12 chars string.