-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override icon with an image URL #639
Conversation
added image attribute to override icon with a URL.
Removed duplicate ` in HTML for renderImage()
Not sure why this is failing, any help would be appreciated. |
Sorry the build pipeline was broken on the |
Moved `renderImage()` to be part of `renderIcon` and prevent unreachable code problem.
I've tried that and it's still failing but this time with no information, odd |
The build can be found here: https://app.travis-ci.com/github/kalkih/mini-media-player/builds/249275837
You need to add the new config option to the |
Updated attribute to icon_image and added it to `MiniMediaPlayerBaseConfiguration`
Great stuff! |
added image attribute to override icon with a URL.