fix icons not showing in new frontend version #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kalkih can you please CR? |
|
Thanks, will take a look tonight. |
|
Looks good! I changed the base branch to |
|
sure will take care of it now |
|
@kalkih rebased and fixed |
|
@kalkih thanks for the CR :-) when can we expect a new release? |
|
Thank you for the contribution! Beta now: https://github.com/kalkih/mini-media-player/releases/tag/v1.14.0-beta Release in a few days maybe, if things seem smooth 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes made recently to the frontend, specifically in the
ha-icon-buttonelement, causes the media buttons to not show up. This PR fixed that issue while maintaining backward compatibility. I tested it locally on my hass instance.You can see the change here:
https://github.com/home-assistant/frontend/blob/master/src/components/ha-icon-button.ts#L10-L11
home-assistant/frontend@0c940be#diff-b7749fac30d4d29a769a04d77d9e72093cfdfecd6e325fba66649575229bde9c
i.e I'm using the latest beta version of HA that was released a couple of hours ago