Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(client): use transmitResultPool to reduce heap allocs #722

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf(client): use transmitResultPool to reduce heap allocs #722

wants to merge 1 commit into from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Feb 25, 2024 •
edited
Loading

WIP

This was referenced Feb 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ijsong
Copy link
Member Author

ijsong commented Feb 25, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ijsong and the rest of your teammates on Graphite Graphite

@ijsong ijsong mentioned this pull request Feb 25, 2024
Merged
@ijsong ijsong self-assigned this Feb 25, 2024
@ijsong ijsong marked this pull request as draft February 25, 2024 13:07
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 49.63%. Comparing base (2bd0a62) to head (94fad3a).

Files Patch % Lines
pkg/varlog/subscribe.go 0.00% 23 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #722      +/-   ##
==========================================
- Coverage   49.72%   49.63%   -0.10%     
==========================================
  Files         235      235              
  Lines       20725    20731       +6     
==========================================
- Hits        10305    10289      -16     
- Misses       9780     9797      +17     
- Partials      640      645       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong mentioned this pull request Feb 28, 2024
Merged
Base automatically changed from perf_pq_prealloc to main March 5, 2024 11:03
@ijsong
perf(client): use transmitResultPool to reduce heap allocs
94fad3a 
Struct pkg/varlog.(transmitResult) is an element of transmitQueue. It is
allocated in heap memory to be pushed into transmitQueue. This PR introduces
transmitResultPool to reuse transmitResult as possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hungryjang hungryjang Awaiting requested review from hungryjang hungryjang is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ijsong ijsong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ijsong