Extend user-defined exception from Exception instead of BaseException

[4m1g0]

I've noticed that the KaitaiStructError extends BaseException instead of Exception. This is contrary to the python official documentation (https://docs.python.org/3/library/exceptions.html):

programmers are encouraged to derive new exceptions from the Exception class or one of its subclasses, and not from BaseException.

exception BaseException: The base class for all built-in exceptions. It is not meant to be directly inherited by user-defined classes (for that, use Exception).

And makes it not possible to catch a decoding exception when using the standard method:

try:
    g = Gif.from_bytes(message_bytes)
except Exception as e:
    print(e)

Is there a specific reason for extending from BaseException that I'm missing?

Thank you very much!

[generalmimon]

For your own convenience, remember a rule of thumb when making pull requests from your fork repository: never commit directly on master of your fork. Create a topic branch for every PR you create. See https://contribute.jquery.org/commits-and-pull-requests/#never-commit-on-master:

When you're working on a fork, you should always think of your master branch as a "landing place" for upstream changes. You should only ever make your commits to topic branches, and your own commits should only ever end up on master after they've been merged in upstream by a maintainer.

[generalmimon]

Good catch, thanks!