Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KS Compiler generates GO files with non standard header #847

Closed
chavacava opened this issue Jan 17, 2021 · 0 comments
Closed

KS Compiler generates GO files with non standard header #847

chavacava opened this issue Jan 17, 2021 · 0 comments
Labels
enhancement
Milestone
v0.10

Comments

@chavacava
Copy link

GO files generated by the KS Compiler do not respect the standard header for generated GO files.

The header should match the pattern ^// Code generated .* DO NOT EDIT\.$, thus the header could be something like:

// Code generated by kaitai-struct-compiler from a .ksy source file. DO NOT EDIT.

This (minor) bug can be fixed by adding the following line at the beginning of the GoCompiler class

override val headerComment = "Code generated by kaitai-struct-compiler from a .ksy source file. DO NOT EDIT."
@generalmimon generalmimon self-assigned this Feb 10, 2021
@generalmimon generalmimon removed their assignment Jul 1, 2021
@generalmimon generalmimon added this to the v0.10 milestone Jul 1, 2021
GreyCat pushed a commit to kaitai-io/kaitai_struct_compiler that referenced this issue Aug 24, 2021
@generalmimon @GreyCat
GoCompiler: fix header comment to match standard Go format
9f96b66 
Fixes kaitai-io/kaitai_struct#847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.10
Development

No branches or pull requests
2 participants
@chavacava @generalmimon