Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: summarize by target language #823

Closed
GreyCat opened this issue Oct 31, 2020 · 0 comments
Closed

CI: summarize by target language #823

GreyCat opened this issue Oct 31, 2020 · 0 comments
Assignees
Milestone

Comments

@GreyCat
Copy link
Member

GreyCat commented Oct 31, 2020

Our current CI grew to be too wide due to all pair combinations of ($TARGET, $VARIETY). Currently it's 33 pairs. It makes it hard to fit into a screen, it's not very easy to comprehend, given that we end up with a table of 33 cols * 220 rows = 7260 cells.

I propose to add a checkbox (enabled by default) to summarize these by ($TARGET). In case if results from different $VARIETY instances inside a $TARGET for a given test are different, we can highlight that as a severe error with a text like "mixed".

@generalmimon generalmimon self-assigned this Apr 5, 2021
generalmimon added a commit to kaitai-io/kaitai_ci_ui that referenced this issue Jun 12, 2021
generalmimon added a commit to kaitai-io/kaitai_ci_ui that referenced this issue Jun 12, 2021
See kaitai-io/kaitai_struct#823

Until now, the order in which variants are shown has
been somewhat "random". Not completely random, it was
just printed in the order in which the "ci.json" files
arrived. But the result was that for instance
the "javascript" variants were in a different order
every time: sometimes it was "node10, node12, node4, node8",
after reload some other one... This is not convenient to
work with, because you need to pay attention to the variant
labels, whose order is not consistent between reloads.
@generalmimon generalmimon added this to the v0.10 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants