Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed small issue which made the extension not working #25

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

bennet-esyoil
Copy link

This fixes a small issue which made the extension (at least for me) not working and i doubt it was working for anybody with the latest release.

@bennet-esyoil
Copy link
Author

tests are passing and I don't know why the package.json & package.lock got changed (there are no changes tho)

@kaishuu0123
Copy link
Owner

@bennet-esyoil
Thank you for your PR.

Did you just delete import { outputPanel } from "./outputPanel";?
If so, please send PR with the that difference only.
(Copy and paste the original file from my project.)

@bennetgallein
Copy link
Contributor

Yes, it's an unused import so it doesn't make any difference. Why should that be in a different PR?

@bennet-esyoil
Copy link
Author

Update: I added back in the unused import.

@kaishuu0123
Copy link
Owner

kaishuu0123 commented Apr 3, 2019

@bennet-esyoil
Where is the essential change of this PR? Or should I merge #26 ?

@bennet-esyoil
Copy link
Author

The important change is in the extension.ts where I change from 'commandManager' to 'CommandManager', because there is no class 'commandManager'. There other PR is according to your instruction 8 days ago. I added back the unused import and created a seperate PR for it.

@kaishuu0123 kaishuu0123 merged commit 96bc78b into kaishuu0123:master Apr 4, 2019
@kaishuu0123
Copy link
Owner

@bennet-esyoil
I understand. thank you for you PR!

@kaishuu0123
Copy link
Owner

@bennet-esyoil
Relased v4.0.4.
Please check if it works without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants