🐛 Fix manual install not supporting configuration url #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
paynejacob
force-pushed
the
issue-764
branch
from
de44ff1
to
19c9216
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 22.79% 22.73% -0.06%
==========================================
Files 22 22
Lines 1610 1614 +4
==========================================
Hits 367 367
- Misses 1179 1183 +4
Partials 64 64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mudler
reviewed
Feb 25, 2023
mudler
changed the title
paynejacob
force-pushed
the
issue-764
branch
4 times, most recently
from
fddc775
to
e474901
Compare
Signed-off-by: Jacob Payne <jacob@spectrocloud.com>
Signed-off-by: Jacob Payne <jacob@spectrocloud.com>
mudler
approved these changes
Mar 8, 2023
Itxaka
pushed a commit
to Itxaka/kairos
that referenced
this pull request
Mar 9, 2023
* fixed manual install not supporting configuration url Signed-off-by: Jacob Payne <jacob@spectrocloud.com> * break out url logic and add testing. Signed-off-by: Jacob Payne <jacob@spectrocloud.com> --------- Signed-off-by: Jacob Payne <jacob@spectrocloud.com> Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #764