Fail if remote url address doesnt exist #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <itxaka@kairos.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 50.14% 50.08% -0.06%
==========================================
Files 48 48
Lines 4573 4582 +9
==========================================
+ Hits 2293 2295 +2
- Misses 2020 2025 +5
- Partials 260 262 +2 ☔ View full report in Codecov by Sentry. |
jimmykarily
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
root@localhost:~# ./kairos-agent manual-install https://www.google.com/test
configuration file not found in remote address
root@localhost:~# ./kairos-agent manual-install https://asdf
Head "https://asdf": dial tcp: lookup asdf on 10.0.2.3:53: no such host
LGTM
renovate bot
added a commit
to kairos-io/provider-kairos
that referenced
this pull request
Sep 19, 2024
…4.1 (#638) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-agent/v2](https://redirect.github.com/kairos-io/kairos-agent) | `v2.14.0` -> `v2.14.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-agent (github.com/kairos-io/kairos-agent/v2)</summary> ### [`v2.14.1`](https://redirect.github.com/kairos-io/kairos-agent/releases/tag/v2.14.1) [Compare Source](https://redirect.github.com/kairos-io/kairos-agent/compare/v2.14.0...v2.14.1) #### What's Changed - Bump go to 1.23.1 by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#526 - Display net info on QR code page by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#525 - chore(deps): update securego/gosec action to v2.21.1 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#528 - fix(deps): update module github.com/kairos-io/kairos-sdk to v0.4.3 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#529 - Fail if remote url address doesnt exist by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#527 - fix(deps): update module github.com/google/go-github/v63 to v64 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#532 - chore(deps): update google/osv-scanner-action action to v1.8.5 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#534 - fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#533 - Improve get partitions and reset spec by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#530 - fix(deps): update module k8s.io/mount-utils to v0.31.1 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#536 - Fix upgrade size calculation inside k8s by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#537 - Do not skip /run when counting the size by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#538 - fix(deps): update module github.com/google/go-github/v63 to v64 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#539 - fix(deps): update module github.com/twpayne/go-vfs/v4 to v5 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#540 - fix(deps): update module github.com/kairos-io/kairos-sdk to v0.4.4 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#541 - fix(deps): update module github.com/google/go-github/v64 to v65 by [@​renovate](https://redirect.github.com/renovate) in [kairos-io/kairos-agent#542 - Move to use our ghw clone by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#535 - Run tests in parallel and output github formats on workflow by [@​Itxaka](https://redirect.github.com/Itxaka) in [kairos-io/kairos-agent#543 **Full Changelog**: kairos-io/kairos-agent@v2.14.0...v2.14.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not failing during manual install and with a remote url if that file doesnt exists, which can lead to users thinking that they are installing from a remote url but they are not, they are just using defaults.
This will make it so it fails if the remote url doesnt exists.
Fixes kairos-io/kairos#2609