forked from facebookincubator/velox
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix NestedLoopJoin with empty build or probe with no join condition (f…
…acebookincubator#9892) Summary: Join with no condition is a cross product. The existing code avoid adding mismatch to the result after cross product because cross product should have matched all input rows (facebookincubator#6010). But there is an exception. When the build or probe side is empty, this cross product is empty too. Hence for left, right, and full join, mismatch should still be produced. This diff fixes this bug by still adding the mismatch to the result if either build or probe side is empty. Reviewed By: Yuhta Differential Revision: D57681090
- Loading branch information
1 parent
3413ef3
commit be9d2be
Showing
3 changed files
with
81 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters