Fix compiler warnings #473
Conversation
The change is acceptable as `ConsumerGroup` is the only client of `ConsumerGroup.Manager`. The defaults on `opts` parameter aren't used and their loss is thus likewise acceptable. Fixes a compiler warning due to a deprecated usage of `Supervisor.Spec.worker/3`.
This enables the usage of `child_spec/1` and removal of the deprecated `Supervisor.Spec.supervisor/3` call. Fixes kafkaex#390.
| @@ -10,15 +10,15 @@ KafkaEx | |||
| [](http://hexdocs.pm/kafka_ex/) | |||
|
|
|||
| KafkaEx is an Elixir client for [Apache Kafka](http://kafka.apache.org/) with | |||
| support for Kafka versions 0.8.0 and newer. KafkaEx requires Elixir 1.5+ and | |||
| support for Kafka versions 0.8.0 and newer. KafkaEx requires Elixir 1.6+ and | |||
There was a problem hiding this comment.
I believe Config as a replacement for Mix.Config was introduced in 1.9. We would need to update this to say 1.9 if we make that change. We should also change mix.exs to require the same version.
There was a problem hiding this comment.
This proposed version bump to 1.6+ (e513413) was meant to get README in sync with the already-changed mix.exs.
While the migration to Config module (1f4e99a), introduced in 1.9.0, was meant to remove the warning for KafkaEx developers. This change has no bearing on KafkaEx users. Though it was my oversight that Elixir 1.6 was still used in the test suite.
Hence I think it's best if I drop 1f4e99a. A decision to bump versions from 1.6 to 1.9 can be made at some other time.
There was a problem hiding this comment.
@joshuawscott Can we merge this?
start_link/1 was added in PR kafkaex#473.
start_link/1 was added in PR kafkaex#473.
The usage of
child_spec/1addresses #390.