Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub actions checks cdn #460

Merged
merged 33 commits into from
Jun 2, 2022
Merged

GitHub actions checks cdn #460

merged 33 commits into from
Jun 2, 2022

Conversation

Argonus
Copy link
Contributor

@Argonus Argonus commented Apr 11, 2022

No description provided.

dantswain and others added 22 commits November 7, 2020 09:03
@dantswain
Add github actions file (no kafka yet)
f1ff283
@dantswain
Remove .travis.yml
a8cb67c
@dantswain
Add docker-compose up
0e118b2
@dantswain
Run integration tests
e539d4d
@dantswain
Docker ps
13fba98
@dantswain
Try services
c5e78b0
@gerbal
Fix indentation in Services; remove docker-compose up
e13cc37
@gerbal
Run CI on all branches
6cbb6cf
@gerbal
Remove duplicate depends_on in docker-compose.yml
f2af33c
@gerbal
Try a straight dockerized CI mimicking Travis
daaa7f7
@gerbal
create test.yml to run CI Test Suite
784f52a
@gerbal
Add common Checks to Github actions CI
039c151
@gerbal
Merge remote-tracking branch 'origin/master' into github-actions-checks
070aee7
@gerbal
Split integration test stages up
51a1574
@gerbal
run test suite on push for testing
8281368
@gerbal
test - wait for setup stage to cache deps
94dd522
@gerbal
Try running test suite args with matrix
888feef
@gerbal
run Suit checks via matrix too
729df7c
@gerbal
Disable fast failures on test matrix
0526100
@gerbal
Correct credo runner command
01e9ee9
@gerbal
improve naming and specify complete command in matrix
51cb92d
@gerbal
try tweaking kafka config to use fewer threads
4ee2cfc
@Argonus Argonus force-pushed the github-actions-checks-cdn branch 5 times, most recently from a2b2443 to 9535e56 Compare April 13, 2022 08:49
@Argonus
Update workflows to work with OTP
e2822db 
- Lock ubuntu version to 20.04
- Steps names to make it more explicit
- Fix OTP
@Argonus Argonus force-pushed the github-actions-checks-cdn branch 2 times, most recently from b51f945 to e93a058 Compare April 21, 2022 12:10
@Argonus Argonus force-pushed the github-actions-checks-cdn branch 2 times, most recently from 3084b71 to c0e547c Compare April 22, 2022 05:58
@Argonus Argonus marked this pull request as ready for review April 22, 2022 06:13
@Argonus
Copy link
Contributor Author

Argonus commented Apr 22, 2022 •
edited
Loading

@dantswain @joshuawscott
Done, after some long fight I've given up and just use the same approach as kafkajs is doing, so moved to confluent-based images.
Currently, there is only the newest version of elixir & erlang in the matrix, but I'm happy to play with other ones as well. What is the earliest version we have to support?

@dantswain
Copy link
Collaborator

@Argonus This is amazing!

The earliest version of Elixir we support is 1.6. If changing that makes this library easier to maintain then I'm totally in favor.

I hate to ask this after all the work you put in, but it looks like there's a bunch of formatting changes here... would you mind making those on a separate PR to make it easier to understand what changed in order to support github actions? Thanks!

@Argonus
Copy link
Contributor Author

Argonus commented Apr 29, 2022

Sure thing, I propose to let's make static checks work only for ~newst version of elixir (that will support 1.6 syntaxes) & run tests for 1.6, 1.10 & 1.13 & corresponding OTP.

@dantswain
Copy link
Collaborator

dantswain commented Apr 29, 2022 via email

@Argonus Argonus mentioned this pull request May 4, 2022
Merged
@Argonus Argonus force-pushed the github-actions-checks-cdn branch 5 times, most recently from 2732384 to f8e37bb Compare May 5, 2022 07:57
@Argonus
Add more otp & elixir versions to matrix
5a3b861 
Support multiple otp & elixir version for tests
Support only newst version for static check.
Handle backward compability in tests
@Argonus Argonus force-pushed the github-actions-checks-cdn branch from f8e37bb to 5a3b861 Compare May 5, 2022 08:11
@Argonus
Copy link
Contributor Author

Argonus commented May 5, 2022 •
edited
Loading

Versions added.
Static code is currently locked at Elixir Version 12. To bump it to version 13, I'll have to drop support for Elixir 1.6.
It looks like sth that could be done in the next major release.

Unfortunately, I'm not able to generate badges for README.md, so this is on you @dantswain :)

@Argonus
Copy link
Contributor Author

Argonus commented May 30, 2022

@dantswain Just a reminder ;)

dantswain
dantswain reviewed May 31, 2022
View reviewed changes
Copy link
Collaborator

@dantswain dantswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this and sorry for the delay. Just a couple questions in the comments.

test/socket_test.exs Outdated Show resolved Hide resolved
.github/workflows/checks.yml Show resolved Hide resolved
test/integration/server0_p_10_p_1_test.exs Show resolved Hide resolved
@dantswain dantswain merged commit 07f0d66 into kafkaex:master Jun 2, 2022
@Argonus Argonus deleted the github-actions-checks-cdn branch November 9, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantswain dantswain dantswain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Argonus @dantswain @gerbal