Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support snappyer 2 #437

Merged
merged 7 commits into from
Mar 29, 2021
Merged

Support snappyer 2 #437

merged 7 commits into from
Mar 29, 2021

Conversation

Argonus
Copy link
Contributor

@Argonus Argonus commented Feb 23, 2021 •
edited
Loading

As the original PR looks a bit abandoned I've created new one cherry-picks of source and minor fixes.

  • Resolved conflicts
  • Use snappy-erlang-nif as default snappy compression
  • Add snappyer as optional snappy compresions

Argonus
Argonus commented Mar 6, 2021
View reviewed changes
lib/kafka_ex/compression.ex Outdated Show resolved Hide resolved
config/test.exs Outdated Show resolved Hide resolved
joshuawscott
joshuawscott reviewed Mar 7, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
Argonus and others added 2 commits March 17, 2021 20:57
@Argonus @joshuawscott
Update README.md
58240bf 
Co-authored-by: Joshua Scott <joshua.scott@gmail.com>
@Argonus
Change default snappy module
185389b
@Argonus
Copy link
Contributor Author

Argonus commented Mar 17, 2021

@joshuawscott Hi
Kayrock related PR is here: kafkaex/kayrock#19
I'm also thinking about making it a bit smarter and in the case of using "kayrock" instead of using snappy use kayrock snappy module. What do you think about it? (I don't really get relationship between this two libs ;P)

jbruggem
jbruggem reviewed Mar 22, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
config/test.exs Outdated Show resolved Hide resolved
mix.exs Outdated Show resolved Hide resolved
@Argonus Argonus requested a review from jbruggem March 24, 2021 09:58
@Argonus Argonus marked this pull request as ready for review March 26, 2021 10:48
@Argonus
Copy link
Contributor Author

Argonus commented Mar 29, 2021

@joshuawscott I've no power to restart travis checks (even on my PR...) but they look like a random fail. Especially that one with timeout on docker pull. If you could be so kind and restart 🙏

joshuawscott
joshuawscott approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@joshuawscott joshuawscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@joshuawscott joshuawscott merged commit ef482fc into kafkaex:master Mar 29, 2021
@Argonus Argonus deleted the support-snappyer-2 branch March 31, 2021 06:47
@Argonus Argonus mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawscott joshuawscott joshuawscott approved these changes

@jbruggem jbruggem jbruggem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Argonus @joshuawscott @jbruggem @getong