Move docker tests into tests folder #9555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9555 +/- ##
==========================================
- Coverage 49.32% 42.91% -6.42%
==========================================
Files 154 154
Lines 13523 13523
==========================================
- Hits 6670 5803 -867
- Misses 5609 6551 +942
+ Partials 1244 1169 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
force-pushed
the
move_test_script
branch
from
41a8c42
to
3c59789
Compare
vitorsavian
approved these changes
Mar 1, 2024
cwayne18
approved these changes
Mar 1, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
This was referenced Mar 8, 2024
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 8, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola
added a commit
that referenced
this pull request
Mar 27, 2024
* Move docker tests into tests folder * Remove old test certs * Update TESTING.md with docker test inf Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Nola derek.nola@suse.com
Proposed Changes
Note: This does not change "where" the docker tests run, which is still in Drone, it just changes the location of the tests.
Types of Changes
Verification
Testing
Linked Issues
#9553
User-Facing Change
Further Comments
Future Work will be explore moving the "Basic" docker tests into a GitHub Action (or incorporating them into the existing Integration or soon to exist E2E Action). I'm not 100% decided on which direction is best. Also, potentially moving "Conformance" docker tests back into PRs is still up in the air.