Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Testing Matrix and Actions bump #9479

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Feb 13, 2024

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Remove the matrix for unit testing, if it passes on ubuntu=latest, its fine, we don't need to waste time testing it on another ubuntu version
  • Move to a different debug action: the new action allows a "timeout for non connection", so if you do use the debugging session, the timeout becomes null and void. No longer will a user have to race against a clock for debugging purposes.
  • Install the version of go given in the go.mod, reduces having to maintain multiple versions of go in infra.
  • setup-go@v4 and above enables caching by default, no need to configure it.

Linked Issues

#9478

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner February 13, 2024 19:02
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c17461) 49.50% compared to head (66eedfe) 15.95%.

❗ Current head 66eedfe differs from pull request most recent head 18635de. Consider uploading reports for the commit 18635de to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9479       +/-   ##
===========================================
- Coverage   49.50%   15.95%   -33.55%     
===========================================
  Files         151      116       -35     
  Lines       13475     9413     -4062     
===========================================
- Hits         6671     1502     -5169     
- Misses       5464     7656     +2192     
+ Partials     1340      255     -1085     
Flag Coverage Δ
e2etests ?
inttests ?
unittests 15.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brandond
brandond previously approved these changes Feb 13, 2024
Signed-off-by: Derek Nola <derek.nola@suse.com>

cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola merged commit 922c5a6 into k3s-io:master Feb 29, 2024
3 checks passed
@dereknola dereknola deleted the unit_test_update branch February 29, 2024 23:41
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 4, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 4, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 4, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 4, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 5, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Mar 5, 2024
cache is now on by default

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants