Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.28] Add a retry around updating a secrets-encrypt node annotations #9125

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

dereknola
Copy link
Member

Backport #9039 to release-1.28

Linked Issues

#9122

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner January 2, 2024 20:28
…o#9039)

* Add a retry around updating a se node annotations

Signed-off-by: Derek Nola <derek.nola@suse.com>
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (5b2d127) 49.90% compared to head (5f1dea7) 45.95%.

Files Patch % Lines
pkg/server/secrets-encrypt.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #9125      +/-   ##
================================================
- Coverage         49.90%   45.95%   -3.96%     
================================================
  Files               148      148              
  Lines             15885    15889       +4     
================================================
- Hits               7928     7302     -626     
- Misses             6695     7428     +733     
+ Partials           1262     1159     -103     
Flag Coverage Δ
e2etests ?
inttests 43.52% <0.00%> (+<0.01%) ⬆️
unittests 18.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit 90367d8 into k3s-io:release-1.28 Jan 7, 2024
15 checks passed
@dereknola dereknola deleted the issue-9119_release-1.28 branch January 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants