Remove GA feature-gates #8970
Merged
Remove GA feature-gates #8970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8970 +/- ##
==========================================
+ Coverage 46.74% 50.04% +3.30%
==========================================
Files 150 150
Lines 15837 15833 -4
==========================================
+ Hits 7403 7924 +521
+ Misses 7232 6645 -587
- Partials 1202 1264 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Nov 29, 2023
harsimranmaan
approved these changes
Dec 6, 2023
pierre-az
pushed a commit
to pierre-az/k3s
that referenced
this pull request
Dec 19, 2023
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jan 10, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jan 10, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This was referenced Jan 10, 2024
brandond
added a commit
to brandond/k3s
that referenced
this pull request
Jan 10, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Jan 12, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Jan 12, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
added a commit
that referenced
this pull request
Jan 12, 2024
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA and cannot be disabled. Signed-off-by: Brad Davidson <brad.davidson@rancher.com> (cherry picked from commit 231cb6e) Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove KubeletCredentialProviders and JobTrackingWithFinalizers feature-gates, both of which are GA since 1.26 and cannot be disabled.
Types of Changes
upstream tracking
Verification
See linked issues
Testing
Linked Issues
User-Facing Change
Further Comments