Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.25] Bump dynamiclistener; reduce snapshot controller log spew #8904

Conversation

brandond
Copy link
Member

Proposed Changes

Types of Changes

bugfix

Verification

See linked issues

Testing

Linked Issues

User-Facing Change

Bumped dynamiclistener to address a race condition that could cause a server to fail to sync its certificates into the Kubernetes secret
Reduced etcd snapshot log spam during initial cluster startup

Further Comments

…l startup

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner November 17, 2023 01:55
Reverts part of the change from 7d38b4a

Pipeline dependencies are apparently broken, and the e2e pipeline has
been getting skipped whenever any other pipeline fails. Ex:
https://drone-pr.k3s.io/k3s-io/k3s/7853

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond force-pushed the bump-dynamiclistener-less-spew_release-1.25 branch from b8beb40 to cf7c788 Compare November 18, 2023 01:45
Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (1570fe1) 17.27% compared to head (cf7c788) 17.27%.
Report is 1 commits behind head on release-1.25.

Files Patch % Lines
pkg/etcd/snapshot_controller.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.25    #8904   +/-   ##
=============================================
  Coverage         17.27%   17.27%           
=============================================
  Files                93       93           
  Lines              6398     6397    -1     
=============================================
  Hits               1105     1105           
+ Misses             5060     5059    -1     
  Partials            233      233           
Flag Coverage Δ
unittests 17.27% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 9d1d824 into k3s-io:release-1.25 Nov 18, 2023
15 checks passed
@brandond brandond deleted the bump-dynamiclistener-less-spew_release-1.25 branch June 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants