Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.25] Handle nil pointer when runtime core is not ready in etcd #8889

Merged

Conversation

vitorsavian
Copy link
Member

Proposed Changes

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Vitor <vitor.savian@suse.com>
@vitorsavian vitorsavian requested a review from a team as a code owner November 16, 2023 22:15
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (5568a2e) 17.27% compared to head (fb73de0) 17.27%.

Files Patch % Lines
pkg/etcd/etcd.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.25    #8889      +/-   ##
================================================
- Coverage         17.27%   17.27%   -0.01%     
================================================
  Files                93       93              
  Lines              6397     6398       +1     
================================================
  Hits               1105     1105              
- Misses             5059     5060       +1     
  Partials            233      233              
Flag Coverage Δ
unittests 17.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitorsavian vitorsavian merged commit 1570fe1 into k3s-io:release-1.25 Nov 16, 2023
14 checks passed
@vitorsavian vitorsavian deleted the core-etcd-manage-learners-1.25 branch May 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants