Wasm shims detection #8751
Wasm shims detection #8751
Conversation
|
CC @vitorsavian |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8751 +/- ##
==========================================
+ Coverage 46.34% 50.44% +4.09%
==========================================
Files 148 150 +2
Lines 15664 15727 +63
==========================================
+ Hits 7260 7933 +673
+ Misses 7248 6538 -710
- Partials 1156 1256 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
flavio
force-pushed
the
wasm-shims-detection
branch
from
a23c575
to
286b0df
Compare
|
@brandond thanks for the feedback, I've applied the changes you proposed and squashed them into the last commit |
|
@dereknola I've applied your suggestions and performed the changes you requested. Can you take another look please? Before merging the PR I'll clean the commit history, I'm talking about the last 2 commits which I left around to simplify the review process |
|
Drone failed because of linter |
Create a generic helper function that finds extra containerd runtimes. The code was originally inside of the nvidia container discovery file. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Discover the containerd shims based on runwasi that are already available on the node. The runtimes could have been installed either by a package manager or by the kwasm operator. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
The containerd configuration on a Linux system now handles the nvidia and the WebAssembly runtimes. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
force-pushed
the
wasm-shims-detection
branch
from
e4d26eb
to
57db827
Compare
|
I've fixed the gofmt issue and cleaned up the commit history |
|
Nice! I'll put aside some time to update the docs |
Proposed Changes
As developers start to experiment building WebAssembly applications, they desire to deploy these workloads on top of Kubernetes, using the same paradigm of "traditional" applications.
The
containerd/runwasiproject provides a way to integrate these workloads into Kubernetes.The WebAssembly workloads require dedicated containerd runtimes to be installed and configured on the node. This PR provides a way to automatically discover the already installed runtimes and properly configure containerd to consume them.
The PR doesn't focus on shipping the pre-built runtimes as part of the k3s installation. I think this should be done by another dedicated PR.
Types of Changes
This PR introduces a new feature. It does that by leveraging the same mechanism used to discover the nvidia runtimes. As you will see, the existing nvidia discovery code has been refactored. Now we have a generic discovery mechanism that can be reused to discover any kind of containerd runtime.
This can be useful not only to add the WebAssembly runtimes, but to discover and configure other runtimes such as gVisor, Kata, ...
Verification
On a node where k3s agent is about to be installed create the following files:
/usr/bin/containerd-shim-lunatic-v1/usr/sbin/containerd-shim-spin-v1/opt/kwasm/bin/containerd-shim-lunatic-v1/usr/bin/nvidia-container-runtime/usr/bin/nvidia-container-runtime-experimentalAll these files can be created with a
touchcommand, they must have the executable permission set.Install the k3s agent, check the containerd
config.toml. Each runtime should have a dedicated section inside of the file.Testing
The new code is covered by dedicated unit tests.
Linked Issues
This PR partially fixes #8700 . This PR doesn't handle the registration of the
RuntimeClassresource for each of the runtimes discovered.User-Facing Change
Further Comments
This PR is somehow related with #6872 . I've discussed with @brandon an alternative approach to his orignal PR. The idea is to focus on the discovery phase of the WebAssembly runtimes. We can expect the user has somehow installed them on the nodes. We will create another PR later on that changes the build scripts of k3s to ensure the most relevant runtimes are pre-installed with k3s.