-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: Simplify and clean up Dockerfile #8244
Conversation
@Leke-Ariyo Thank you for the community PR. Per CNCF guidelines, all commits must be signed to pass DCO. Please see https://github.com/k3s-io/k3s/pull/8244/checks?check_run_id=16194110860. |
done @dereknola |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8244 +/- ##
==========================================
+ Coverage 45.11% 49.22% +4.11%
==========================================
Files 148 148
Lines 15674 15674
==========================================
+ Hits 7071 7716 +645
+ Misses 7457 6715 -742
- Partials 1146 1243 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We can ignore the failure on secrets-encryption, the test is flaky and is being fixed in another PR. |
Thanks, sounds good @dereknola . I have committed your suggestion |
Looks like your new commit was signed, so you invalidated the DCO again. |
I just signed |
@Leke-Ariyo We are out of code freeze (last 2 months releases were back to back). Can you please rebase off master/resolve your conflicts? |
dbc89a2
to
3675dd8
Compare
Signed-off-by: leke-ariyo <lekeariyo2015@gmail.com>
looks like all is good to go, I do not have merge access |
we are in code freeze for a +k3s2 release. Nothing is being merged until that is complete. |
Signed-off-by: leke-ariyo <lekeariyo2015@gmail.com>
Signed-off-by: leke-ariyo <lekeariyo2015@gmail.com>
Signed-off-by: Leke Ariyo <lekeariyo2015@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Leke Ariyo <lekeariyo2015@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Leke Ariyo <lekeariyo2015@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Leke Ariyo <lekeariyo2015@gmail.com> Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
What this PR does / why we need it:
Optimizes the Dockerfile for better efficiency and readability.
Special notes for your reviewer:
Please pay attention to the Trivy installation simplification.
Details:
How to test this PR:
Screenshots:
N/A
Additional context:
This optimization aims to make the Dockerfile more maintainable and efficient.