Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.26] Allow k3s to customize apiServerPort on helm-controller #7874

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

dereknola
Copy link
Member

Proposed Changes

Backport #7834 to 1.26

Linked Issues

#7871

User-Facing Change


Further Comments

Signed-off-by: Daishan Peng <daishan@acorn.io>
@dereknola dereknola requested a review from a team as a code owner July 5, 2023 16:55
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e62e7bc) 10.03% compared to head (f28d0d8) 10.03%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.26    #7874      +/-   ##
================================================
- Coverage         10.03%   10.03%   -0.01%     
================================================
  Files               150      150              
  Lines             10893    10894       +1     
================================================
  Hits               1093     1093              
- Misses             9575     9576       +1     
  Partials            225      225              
Flag Coverage Δ
unittests 10.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/server/server.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereknola dereknola merged commit 6afe691 into k3s-io:release-1.26 Jul 5, 2023
6 checks passed
@dereknola dereknola deleted the api_port_126 branch July 7, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants