Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.24] E2E Backports - June #7726

Merged
merged 5 commits into from
Jun 10, 2023

Conversation

dereknola
Copy link
Member

Proposed Changes

Backports to 1.25:

Types of Changes

Backports, largely around tests

Linked Issues

#7689

User-Facing Change

* Shortcircuit commands with version or help flags #7683
* Add Rotation certification Check, remove func to restart agents #7097
* E2E: Sudo for RunCmdOnNode #7686

Further Comments

dereknola and others added 5 commits June 9, 2023 10:09
* Shortcircuit search with help and version flag

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Keep functions seperate

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
* Add Certification Test to Validate Cluster

Signed-off-by: est-suse <esteban.esquivel@suse.com>

* Fix to stop/start for k3s certificate rotation

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: est-suse <esteban.esquivel@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Co-authored-by: est-suse <esteban.esquivel@suse.com>
Co-authored-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner June 9, 2023 17:11
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 16.66% and no project coverage change.

Comparison is base (313a3b9) 10.09% compared to head (986efec) 10.09%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.24    #7726   +/-   ##
=============================================
  Coverage         10.09%   10.09%           
=============================================
  Files               149      149           
  Lines             10742    10746    +4     
=============================================
+ Hits               1084     1085    +1     
- Misses             9435     9437    +2     
- Partials            223      224    +1     
Flag Coverage Δ
unittests 10.09% <16.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/configfilearg/defaultparser.go 16.66% <0.00%> (+1.28%) ⬆️
pkg/configfilearg/parser.go 72.89% <20.00%> (-1.65%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dereknola dereknola merged commit 2105147 into k3s-io:release-1.24 Jun 10, 2023
@dereknola dereknola deleted the june_backport_124 branch July 7, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants